Intermediate grammar · Lesson 11 · B1

how long have you (been) ... ?

For something that started in the past and is still going on, ask and answer with the present perfect: how long have you been married, not how long are you married.

Start the lesson

17Steps · about 30 minutes

how long have you (been) ... ?: start

In this lesson

Started in the past, still true nowA1 screen of questions
Simple or continuous with how longB3 screens of questions
live and work: either form, except with alwaysC2 screens of questions
I haven't done something since or forD1 screen of questions
Put it together+4 screens of mixed questions

Point A of 4

Started in the past, still true now

Gary and Lynne got married thirty years ago today. It is their pearl anniversary, and Gary has booked a table at the same Italian restaurant as last year, and the year before.

They are married. That is the present.

How long have they been married? They have been married for thirty years. That is the present perfect, because the marriage started in the past and continues now. Not How long are they married? and not They are married for thirty years.

Present Present perfect
Nan is in hospital. She's been in hospital since Friday.
We know each other very well. We've known each other since primary school.
Do they have a dog? How long have they had their dog?
He's waiting for a taxi. He hasn't been waiting very long.
  • Nan's been in hospital since Friday.
  • We've known each other since primary school.
  • How long have they had their dog?
  • He hasn't been waiting very long.

Point A · Extra practice

Complete each sentence with the present perfect simple or continuous and the words in brackets.

  1. Ella and Rob married for ten years. (be)

  2. How long you in this flat? (live)

  3. We each other since primary school. (know)

Point B of 4

Simple or continuous with how long

I've known, I've had, I've lived are present perfect simple. I've been learning, I've been waiting are present perfect continuous.

When the subject is how long, the continuous is usually the natural choice (Unit 10). Verbs that resist the continuous, such as know and like, stay simple. Units 4 and 10 explain this; Unit 17 deals with have.

  • I've been learning Portuguese since March.
  • It's been drizzling all day.
  • Aunt Carol has been running the same chip shop for twenty-five years.
  • "How long have you been driving?" "Since I was eighteen."
  • How long have you known Dev? (not have you been knowing)
  • I've had this coat for years. (not I've been having)

Point B · Exercise 11.1 · part 1 of 3

Which is right? Write the correct form.

  1. Example

    Owen is my oldest friend. I trust (I trust / I've trusted) him completely.

    AnswerOwen is my oldest friend. I trust him completely.
  2. What a lovely garden. How long (do you live / have you lived) in this house?

  3. Take a coat if you're going out. (It's snowing / It's been snowing).

  4. The traffic (is / has been) dreadful since they closed the bridge.

  5. Sorry, the bus was late. (Are you sitting / Have you been sitting) here for ages?

Point B · Exercise 11.1 · part 2 of 3

Which is right? Write the correct form.

  1. We moved last month. (We're living / We've been living) in Mill Lane now.

  2. Rosie only joined the team last week. (I don't know / I haven't known) her for long.

  3. Callum is in Belfast. (He's / He's been) there for a job interview.

  4. That's a really old phone. How long (do you have / have you had) it?

Point B · Exercise 11.1 · part 3 of 3

Which is right? Write the correct form.

  1. I'm not well. (I'm feeling / I've been feeling) sick since breakfast.

Point C of 4

live and work: either form, except with always

With live and work you may use either the continuous or the simple. With always, use the simple.

  • Mr Okafor has been living next door for a long time.
  • Mr Okafor has lived next door for a long time.
  • How long have you been working at the library?
  • How long have you worked at the library?
  • I've always lived by the sea. (not I've always been living)

Point C · Exercise 11.2 · part 1 of 2

Read each situation and write a question using the words in brackets.

  1. Example

    A friend tells you that her nan is in hospital. You ask her:

    (how long / your nan / hospital?)

    How long has your nan been in hospital?

    AnswerHow long has your nan been in hospital?
  2. You know that Becky is a good friend of Laura's. You ask Becky:

    (how long / you / know / Laura?)

  3. Your friend's brother went to Canada a while ago and he is still there. You ask your friend:

    (how long / brother / in Canada?)

  4. You meet a man who tells you he teaches swimming. You ask him:

    (how long / you / teach / swimming?)

  5. Pete always wears the same flat cap. It is very old. You ask him:

    (how long / you / have / that cap?)

Point C · Exercise 11.2 · part 2 of 2

Read each situation and write a question using the words in brackets.

  1. You are talking to a friend about Zara, who now works at the hospital. You ask your friend:

    (how long / Zara / work / hospital?)

  2. You meet somebody on a train. She says that she lives in Glasgow. You ask her:

    (you / always / live / in Glasgow?)

Point D of 4

I haven't done something since or for

To say when something last happened, use the present perfect simple in the negative with since or for.

  • I haven't heard from Jade since Easter. (Easter was the last time she was in touch)
  • Uncle Ray hasn't been fishing for years. (the last time he went was years ago)

Point D · Extra practice

Write a negative sentence with the present perfect and since or for.

  1. The last time I saw Jade was at Easter. I Easter.

  2. The last time it rained was three weeks ago. It three weeks.

  3. The last time Ray went fishing was years ago. Ray years.

Put it together · Exercise 11.3 · part 1 of 4

Complete B's answers to A's questions.

  1. Example

    A: Your nan's in hospital, isn't she? B: Yes, she has been in hospital since Friday.

    AnswerYes, she has been in hospital since Friday.
  2. Example

    A: Do you see Kerry much? B: No, I haven't seen her for two months.

    AnswerNo, I haven't seen her for two months.
  3. A: Is Lewis married? B: Yes, he married for six years.

  4. A: Is Freya married? B: Yes, she married to a Danish chap.

  5. A: Do you still play squash? B: No, I squash for years.

  6. A: Are you waiting for the 42? B: Yes, I for about half an hour.

Put it together · Exercise 11.3 · part 2 of 4

Complete B's answers to A's questions.

  1. A: Tasha and you go back years, don't you? B: Yes, we each other since primary school.

  2. A: Dad's never off sick, is he? B: No, he off sick since I've known him.

  3. A: Your sister lives in Spain, doesn't she? B: Yes, she in Valencia.

  4. A: Kemal lives in Leeds, doesn't he? B: Yes, he in Leeds for many years.

Put it together · Exercise 11.3 · part 3 of 4

Complete B's answers to A's questions.

  1. A: Is Sam playing on his computer? B: Yes, he on it all evening.

  2. A: Do you listen to the radio a lot? B: No, I the radio since last month.

  3. A: Have you got toothache? B: Yes, I toothache all day.

  4. A: Do you go to the theatre much? B: No, I to the theatre for ages.

Put it together · Exercise 11.3 · part 4 of 4

Complete B's answers to A's questions.

  1. A: Would you like to see the Northern Lights one day? B: Yes, I to see the Northern Lights. (use always / want)